mailgun: enable mangling and syncing with subdomains - #2724
Open
ubiratansoares wants to merge 1 commit into
Open
mailgun: enable mangling and syncing with subdomains#2724ubiratansoares wants to merge 1 commit into
ubiratansoares wants to merge 1 commit into
Conversation
Dry-run check results |
ubiratansoares
force-pushed
the
u/mailgun-legacy-email-routes
branch
2 times, most recently
from
September 3, 2026 17:20
e9fbf20 to
24694d0
Compare
5 tasks
ubiratansoares
marked this pull request as ready for review
September 3, 2026 18:33
ubiratansoares
requested review from
Mark-Simulacrum,
emilyalbini,
jdno and
marcoieni
as code owners
September 3, 2026 18:33
marcoieni
reviewed
Sep 4, 2026
| "list+bot@example.com", | ||
| "list+bot@legacy-lists.example.com", | ||
| ] { | ||
| let re = regex::Regex::new(&mangle_address("list@example.com").unwrap()); |
Member
There was a problem hiding this comment.
let's move this above the for loop so we construct the regex once
ubiratansoares
force-pushed
the
u/mailgun-legacy-email-routes
branch
from
September 4, 2026 10:55
24694d0 to
43147e3
Compare
marcoieni
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI disclosure
I used Claude Code to get clarifications about these changes and deep search in the wild info on Mailgun's API rate limits.
Towards rust-lang/infra-team#297
We tweak the mangling logic to handle a special subdomain we'll introduce to enable the migration (of lists provisioned by
team) from Mailgun to Google Groups.syncdoes not support dry-runs for Mailgun in CI, so I had to test these changes manually.A part of the output looks like this, I won't share it full since it'd disclose encrypted emails:
This approach will delete and (re)create all 96 lists we currently have, rather than updating them in-place. This should be fine from the rate-limiting perspective for a single deploy (no official numbers, but 300 rpm mentioned on issues like this).
After lots of pain, I think this path worths compared with trying to update existing rules in-place and keeping guardrail checks to ensure consistency between the current and the new state (that was my first attempt).
Happy to get input in case I missed something.