Skip to content

Removes fragile tests which depend on rustc output - #15

Merged
martynp merged 1 commit into
mainfrom
remove_compiler_tests
Jul 21, 2026
Merged

martynp merged 1 commit into
mainfrom
remove_compiler_tests

Conversation

@martynp

@martynp martynp commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@martynp martynp added this to the v1.2.0 milestone Jul 12, 2026
@martynp
martynp requested a review from Copilot July 21, 2026 08:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a set of codegen UI compile-fail tests that primarily asserted rustc’s own type-error diagnostics (which are prone to churn across toolchain updates), and updates remaining UI snapshot outputs to align with current compiler formatting.

Changes:

  • Removed several ui-fail / ui-fail-{stable,nightly} tests (and associated .stderr snapshots) that depended on unstable rustc type-error output.
  • Updated multiple remaining ui-fail-stable .stderr snapshots to match current diagnostic spans/formatting.
  • Documented the removal in the Unreleased section of CHANGELOG.md.

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/codegen/tests/ui-fail/uri_display_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail/typed-uri-bad-type.rs Removed brittle UI test case.
core/codegen/tests/ui-fail/route-type-errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail/responder-types.rs Removed brittle UI test case.
core/codegen/tests/ui-fail/from_form_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail/catch_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/uri_display.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/uri_display_type_errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-stable/uri_display_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/typed-uris-invalid-syntax.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/typed-uris-bad-params.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/typed-uri-bad-type.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-stable/typed-uri-bad-type.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/route-type-errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-stable/route-type-errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/route-path-bad-syntax.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/route-attribute-general-syntax.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/responder.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/responder-types.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-stable/responder-types.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/from_param.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/from_form.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/from_form_type_errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-stable/from_form_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/from_form_field.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/catch_type_errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-stable/catch_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-stable/bad-ignored-segments.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-stable/async-entry.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-nightly/uri_display_type_errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-nightly/uri_display_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-nightly/typed-uri-bad-type.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-nightly/typed-uri-bad-type.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-nightly/route-type-errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-nightly/route-type-errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-nightly/responder-types.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-nightly/responder-types.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-nightly/from_form.stderr Updated expected diagnostic output formatting/spans.
core/codegen/tests/ui-fail-nightly/from_form_type_errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-nightly/from_form_type_errors.rs Removed brittle UI test case.
core/codegen/tests/ui-fail-nightly/catch_type_errors.stderr Removed snapshot for deleted brittle test.
core/codegen/tests/ui-fail-nightly/catch_type_errors.rs Removed brittle UI test case.
CHANGELOG.md Documented removal of brittle UI tests under Unreleased.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@martynp
martynp merged commit 4536019 into main Jul 21, 2026
12 checks passed
@martynp
martynp deleted the remove_compiler_tests branch July 25, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants