Removes fragile tests which depend on rustc output - #15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes a set of codegen UI compile-fail tests that primarily asserted rustc’s own type-error diagnostics (which are prone to churn across toolchain updates), and updates remaining UI snapshot outputs to align with current compiler formatting.
Changes:
- Removed several
ui-fail/ui-fail-{stable,nightly}tests (and associated.stderrsnapshots) that depended on unstablerustctype-error output. - Updated multiple remaining
ui-fail-stable.stderrsnapshots to match current diagnostic spans/formatting. - Documented the removal in the Unreleased section of
CHANGELOG.md.
Reviewed changes
Copilot reviewed 43 out of 43 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/codegen/tests/ui-fail/uri_display_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail/typed-uri-bad-type.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail/route-type-errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail/responder-types.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail/from_form_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail/catch_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/uri_display.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/uri_display_type_errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-stable/uri_display_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/typed-uris-invalid-syntax.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/typed-uris-bad-params.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/typed-uri-bad-type.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-stable/typed-uri-bad-type.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/route-type-errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-stable/route-type-errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/route-path-bad-syntax.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/route-attribute-general-syntax.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/responder.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/responder-types.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-stable/responder-types.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/from_param.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/from_form.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/from_form_type_errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-stable/from_form_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/from_form_field.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/catch_type_errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-stable/catch_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-stable/bad-ignored-segments.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-stable/async-entry.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-nightly/uri_display_type_errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-nightly/uri_display_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-nightly/typed-uri-bad-type.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-nightly/typed-uri-bad-type.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-nightly/route-type-errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-nightly/route-type-errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-nightly/responder-types.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-nightly/responder-types.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-nightly/from_form.stderr | Updated expected diagnostic output formatting/spans. |
| core/codegen/tests/ui-fail-nightly/from_form_type_errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-nightly/from_form_type_errors.rs | Removed brittle UI test case. |
| core/codegen/tests/ui-fail-nightly/catch_type_errors.stderr | Removed snapshot for deleted brittle test. |
| core/codegen/tests/ui-fail-nightly/catch_type_errors.rs | Removed brittle UI test case. |
| CHANGELOG.md | Documented removal of brittle UI tests under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.