fix(nixos): preserve legacy pool configuration - #70
Merged
Merged
Conversation
Keep legacy volume and distributed configurations evaluable, reject invalid multi-pool singleton expressions, and exercise the module checks in CI. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Apply the CI formatter output to the pools compatibility implementation and its regression test. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Use the NixOS evaluation entry point available from the pinned nixpkgs path in the module-options regression check. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Import the NixOS evaluation entry point with a path-preserving expression so flake evaluation can resolve the pinned nixpkgs source. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Add the explicit empty nodes list required by the computed compatibility pool before rendering local endpoints. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Daholli
reviewed
Sep 18, 2026
Use a Nix changed-option migration for legacy volumes while removing the short-lived distributed compatibility interface. Co-Authored-By: heihutu <heihutu@gmail.com> Co-Authored-By: zhi22915 <qiuzgang@gmail.com>
Daholli
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #57.\n\nRestores evaluable compatibility for legacy volumes and distributed configurations, rejects invalid multi-pool singleton expressions, adds module-option regression coverage, and builds those checks in CI.