Skip to content

feat: export SourceType enum - #886

Open
codebutler wants to merge 1 commit into
s-yadav:masterfrom
codebutler:patch-1
Open

feat: export SourceType enum#886
codebutler wants to merge 1 commit into
s-yadav:masterfrom
codebutler:patch-1

Conversation

@codebutler

@codebutler codebutler commented Apr 15, 2025

Copy link
Copy Markdown

Describe the issue/change

Gives consumers of this library a way to properly avoid triggering the eslint rule @typescript-eslint/no-unsafe-enum-comparison.

Add CodeSandbox link to illustrate the issue (If applicable)

Describe specs for failing cases if this is an issue (If applicable)

Describe the changes proposed/implemented in this PR

Add export.

Link Github issue if this PR solved an existing issue

Example usage (If applicable)

import { SourceType } from "react-number-format";

onValueChange={(values, sourceInfo) => {
  if (sourceInfo.source === SourceType.event) {
    // do something
  }
}}

Screenshot (If applicable)

Please check which browsers were used for testing

  • Chrome
  • Chrome (Android)
  • Safari (OSX)
  • Safari (iOS)
  • Firefox
  • Firefox (Android)

Gives consumers of this library a way to properly avoid triggering the eslint rule `@typescript-eslint/no-unsafe-enum-comparison`
@davbrito

Copy link
Copy Markdown
image

Direct comparison with a string also triggers a typescript error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants