fix(keypress): support android backspace in onKeyDown event - #892
Open
shbov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
On Huawei devices, pressing backspace on the virtual keyboard does nothing because the emitted event is different from the standard Backspace event.
Add CodeSandbox link to illustrate the issue (If applicable)
In the project’s sandbox on Huawei devices, pressing backspace on the virtual keyboard does nothing because the emitted event differs from the standard
Backspaceevent.Describe the changes proposed/implemented in this PR
Added support for keyCode
229, which is used as aBackspaceevent on some Android devices (e.g., Huawei).Please check which browsers were used for testing