Fix crash when opening the direct file picker - #10
Open
jpmartins98 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a user-facing crash triggered by clicking Open File Directly on the landing page.
Problem and root cause
LandingPage._open_file_dialog()callsQFileDialog.getOpenFileNames(), butQFileDialogis not imported bylanding_page.py. The first click therefore raisesNameErrorbefore the native file picker can be displayed. This is platform-independent and affects Windows, Linux, and macOS.Changes
QFileDialogfromPySide6.QtWidgets.Why this PR is needed
Opening individual Smart Switch files is a primary workflow for
.data,.penc,.apk,.bk,.smem, contacts, and call-log files. The workflow is currently unusable whenever this missing symbol is reached. The fix is deliberately isolated from the other UI and build changes.Compatibility and risk
This does not change file parsing, extraction, dialog filters, or public APIs. It only restores the missing Qt import and adds regression coverage.
Validation
uv run pytest -q tests/test_file_dialogs.py: 4 passed.AI disclosure
This PR and all changes introduced by it, including implementation, tests, and this description, were generated by OpenAI Codex under the user's direction. The resulting changes were reviewed through source inspection and the validation described above