tui: drop a useless assignment in the prompt renderer - #2
Merged
Merged
Conversation
CodeQL (go/useless-assignment-to-local) flagged the result of the second screen.Text call, which nothing read. Assign the label position once and use it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeQL reports
go/useless-assignment-to-localon the prompt renderer: the value returned by the secondscreen.Textcall was stored inxand never read.The label position is now computed once into
valStart, which is also what the cursor calculation below it uses. No behaviour change — the same twoTextcalls happen at the same columns.Closes the only open code-scanning alert.