Repository navigation
Add Implement Sentinel Spec Skill - #11
Merged
Merged
Conversation
nlordell
reviewed
Aug 26, 2026
|
|
||
| ## Step 1 — Run the target spec | ||
|
|
||
| This skill's one hard prerequisite is that the current repo's `Justfile` exposes: |
Collaborator
There was a problem hiding this comment.
nit: "current repo" seems incorrect here right? I feel like the safenet repo should be referenced directly in the skill.
Contributor
Author
There was a problem hiding this comment.
I wanted to use current repo, so that anyone could use this skill in their repo as long as a just commands with that specific format is exposed. It doesn't have to be the one from the safenet repo. I.e. florent could use the same for his implementation as long as that command is available.
nlordell
approved these changes
Aug 26, 2026
nlordell
left a comment
nlordell
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just one nit on wording "current repo" lacks precision IMO.
Also, generally, I think the skill is a little long and uses a lot of context and could be potentially shortened a bit and made more succinct.
Skill that make necessary adjustments to fullfill a Sentinel spec. Design Decisions: - Require that a just script for spec running of a specific format (just test-integration-sentinel-engine <test-vectors-repo> <spec>) is available. - Rather reference other agent.md files instead of assuming Safenet Rust implementation details (if then only as examples)
rmeissner
force-pushed
the
feat/implement_sentinel_spec_skill
branch
from
August 26, 2026 14:20
452b148 to
9d5ab51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill that make necessary adjustments to fullfill a Sentinel spec.
Design Decisions: