feat: add --network and --country flags to rescan - #33
Merged
Merged
Conversation
The rescan API accepts sandbox network settings, but the CLI never sent them. Add --network (default true) and --country (default US) to the rescan command and forward both to the /rescan endpoint, with test coverage for the new request body fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The rescan API accepts sandbox network settings, but the CLI never sent them. This adds two flags to
rescanand forwards them to/v1/files/<sha256>/rescan:--network(defaulttrue) — allow sandbox internet access, sent asnetwork_enabled--country(defaultUS) — two-letter VPN exit country used when network access is enabledService.Rescannow takesnetworkEnabled bool, country string; all call sites incmd/scanui.go(scan, rescan, and archive-child paths) pass them through.Test plan
go build ./...,go vet ./...,go test ./...all passTestRescanassertsnetwork_enabledandcountryare present in the request bodyNote
The flags are registered on
rescanCmdonly, soscan(which triggers a rescan for archive children and--force) uses the defaultsnetwork_enabled=true/country=USwithout a way to override them. Happy to mirror the flags ontoscanin a follow-up if you want that knob there too.