Repository navigation
Replace unsound RefCell usage with UnsafeCell for error buffer - #595
Merged
Merged
Conversation
sagebind
approved these changes
Oct 6, 2026
sagebind
left a comment
sagebind
left a comment
Owner
There was a problem hiding this comment.
Thanks for fixing this! Sorry about the delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #589.
RefCell's interface cannot be soundly used for this purpose because libcurl needs a long-lived mutable pointer to the error buffer.For users, this PR should not have any visible effect except for slight changes in performance perhaps. The auto trait implementations (
Send/!Sync/Freeze) ofEasy2do not change.