Skip to content

curl-sys: define HAVE_POLL so vendored curl >= 8.11 uses poll() instead of select() #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlgrpe wants to merge 1 commit into
base: main
Choose a base branch
from
Open

curl-sys: define HAVE_POLL so vendored curl >= 8.11 uses poll() instead of select() #685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions curl-sys/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,12 @@ fn main() {
// poll() on various versions of macOS are janky, so only use it
// on non-macOS unix-likes. This matches the official default
// build configuration as well.
//
// curl 8.x gates select.c on HAVE_POLL (HAVE_POLL_FINE is the
// pre-8.x name). Without it libcurl silently falls back to
// select(), and any socket with fd >= FD_SETSIZE (1024) fails
// with CURLE_COULDNT_CONNECT right after the TCP handshake.
.define("HAVE_POLL", None)
.define("HAVE_POLL_FINE", None);
}

Expand Down
Loading