Update htmlunit3-driver to 4.45.0 - #382
Conversation
📝 WalkthroughWalkthroughThe ChangesDependency Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@project/Versions.scala`:
- Line 19: Fix the version mismatch between seleniumHtmlUnitDriver and selenium
in the Versions.scala file. The seleniumHtmlUnitDriver variable is set to 4.45.0
but the selenium version is 4.31.0, and per HtmlUnit3-Driver compatibility
guidance these versions must align. Either update seleniumHtmlUnitDriver from
4.45.0 to 4.31.0 to match the selenium version, or upgrade the selenium version
to 4.45.0 to match the driver.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d4a1c12-a329-4de6-9bd1-94a7e99f4740
📒 Files selected for processing (1)
project/Versions.scala
|
|
||
| val selenium = "4.31.0" | ||
| val seleniumHtmlUnitDriver = "4.30.0" | ||
| val seleniumHtmlUnitDriver = "4.45.0" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
For org.seleniumhq.selenium htmlunit3-driver 4.45.0, what Selenium Java versions are supported/recommended? Please include official release notes, Maven metadata (POM dependencies), and any compatibility guidance for mixing htmlunit3-driver 4.45.0 with selenium-java 4.31.0.
💡 Result:
Supported/recommended Selenium Java versions for org.seleniumhq.selenium:htmlunit3-driver 4.45.0: No official evidence found for a release/tag or published Maven artifact named 4.45.0 for htmlunit3-driver in the sources retrieved. The official compatibility table and GitHub release pages we found only show up through 4.44.0 (latest) for htmlunit3-driver, and the compatibility guidance is keyed by “selenium” == “htmlunit-driver” version numbers (i.e., HtmlUnit-Driver version aligns with Selenium version). [1] What we can say with evidence (closest official guidance, htmlunit3-driver 4.44.0 and compatibility): 1) HtmlUnit 3 Driver versions map directly to Selenium versions Starting with Selenium 4.5, the driver uses the same version numbers for the driver; e.g., HtmlUnit-Driver 4.41.0 is for Selenium 4.41.0. [1] 2) Therefore, for htmlunit3-driver 4.45.0 you should expect Selenium Java 4.45.0 compatibility (not 4.31.0) Because the project’s guidance is “same version number” mapping, htmlunit3-driver X is intended for Selenium X. [1] 3) Java runtime requirement (driver-side) is at least JDK 17 for the newest htmlunit3-driver line we found The official release notes for htmlunit3-driver 4.44.0 state “requires JDK 17”. [2] Maven metadata / POM dependencies I did not retrieve the actual htmlunit3-driver 4.45.0 POM from Maven Central, because the sources we found only clearly list releases up to 4.44.0 (and the Central listing snippets we saw weren’t specific to 4.45.0). [3][1] Official release notes Same issue: the official release notes page we retrieved is for 4.44.0 (not 4.45.0), and it explicitly ties compatibility to Selenium 4.44.0 and requires JDK 17. [2] Compatibility guidance for mixing htmlunit3-driver 4.45.0 with selenium-java 4.31.0 Based on the official compatibility rule (“same version numbers”) in the compatibility table, htmlunit3-driver 4.45.0 is not intended to pair with selenium-java 4.31.0; instead, it should be paired with selenium-java 4.45.x. [1] Practical recommendation: don’t mix these versions - Use selenium-java 4.45.0 (or 4.45.x that matches the driver’s intended Selenium version) with htmlunit3-driver 4.45.0, rather than selenium-java 4.31.0. [1] - If you must stay on selenium-java 4.31.0, use the matching htmlunit3-driver version for Selenium 4.31.0 according to the same mapping rule. [1] If you want, tell me whether you already have the Maven Central coordinates/artifact you’re seeing for “4.45.0”; with the correct POM URL (or the artifact’s existence confirmation), I can extract the exact supported/recommended Selenium version from the official release notes and list the actual POM dependencies for 4.45.0, plus confirm how (and whether) it aligns with selenium-java 4.31.0.
Citations:
- 1: https://github.com/SeleniumHQ/htmlunit-driver/blob/master/docs/compatibility.md
- 2: https://github.com/SeleniumHQ/htmlunit-driver/releases/tag/4.44.0
- 3: https://repo.maven.apache.org/maven2/org/seleniumhq/selenium/htmlunit3-driver/
Fix version mismatch: htmlunit3-driver 4.45.0 is incompatible with selenium 4.31.0.
Per official HtmlUnit3-Driver compatibility guidance, driver and Selenium versions must align (htmlunit3-driver 4.X pairs with selenium-java 4.X). The version pairing here is incorrect. Either downgrade seleniumHtmlUnitDriver to 4.31.0 to match selenium at 4.31.0, or upgrade selenium to 4.45.0 to match the driver.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@project/Versions.scala` at line 19, Fix the version mismatch between
seleniumHtmlUnitDriver and selenium in the Versions.scala file. The
seleniumHtmlUnitDriver variable is set to 4.45.0 but the selenium version is
4.31.0, and per HtmlUnit3-Driver compatibility guidance these versions must
align. Either update seleniumHtmlUnitDriver from 4.45.0 to 4.31.0 to match the
selenium version, or upgrade the selenium version to 4.45.0 to match the driver.
|
Superseded by |
About this PR
📦 Updates org.seleniumhq.selenium:htmlunit3-driver from
4.30.0to4.45.0📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
Summary by CodeRabbit