Repository navigation
feat(release): attach verified Windows assets after owner publishes a GitHub Release - #147
Merged
Merged
Conversation
22 of 32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Let the repository owner publish v1.4.0 directly in GitHub's UI without manually uploading a ~1.55 GB set of files. GitHub Actions must not create or publish the tag/release; it only attaches already-verified assets to a release the owner has published.
Changes
Attach verified release assetsonrelease: publishedfor non-prerelease owner-published releases.mainSHA and CMake version matches, and an unexpired, successfulPrepare manual releaseartifact exists at that exact SHA.manual-release-assetsfrom that preparation run only; re-hash all four payloads, inspect ZIP/TAR and SPDX with the newly merged release asset validator (feat(release): add independent manual-release asset integrity gate #146), upload exactly five named assets, and independently verify GitHub asset names and lengths.Acceptance / release safety
mainchanges on integration, so do not reuse the old v1.4.0 asset bundle from eb64133. Wait for CI, Windows clean-host checks, website, and Prepare manual release to pass on the new integrated commit; test the new attachment job when the owner publishes.No stable GitHub Release is created by this PR.