Repository navigation
test(multi): under a chromium default, a site's multi env gets chromium unnamed, which browser_sign_in signs in after each reset (FD-4961) - #617
Merged
earakely-scale merged 1 commit intoNov 11, 2026
Conversation
…um unnamed, which browser_sign_in signs in after each reset M8.14's done-when, on the code #598 and M5.15 shipped: with the config's default website browser the chromium computer, a multi env with a site that offers session names no browser and deploys chromium as its computer child; browser_sign_in signs it in, reset_env leaves it signed out, and a second browser_sign_in signs it in again. A unit test covers the config's default beside the run's override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/fd-4961-m814-browser_envs-on-the-multi-env
branch
November 11, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
M8.14 (FD-4961): the default website browser is added to a multi env with sites, and signed in. #598 and M5.15 (#556) already built all of it, so this PR proves M8.14's "done when" on the code that shipped and adds no production code.
browser_envsgets the run's browser,website_browser_env_id, which resolves to the config'sdefault_website_browser_env_id. Under a chromium default it deploys chromium unnamed, on a sandbox of its own.browser_envs = []deploys none, andchild_envs.chromiumcarries its settings, such asstart_urls.browser_sign_in {site, user, browser?}step does, placed after the load and again afterreset_env. Since feat(multi): a multi env names its website browser (browser_envs), a browser computer on a sandbox of its own #598, browser steps find abrowser_envsbrowser computer.Until now the default was tested only through the run override, and sign-in only on a desktop computer carrying a browser app, never on a browser computer the multi env added itself.
What changes
Tests only:
browser_computer_test.py): under a config whose default website browser is the chromium computer, a multi env with a site that offerssessionnames no browser and deploys chromium as its one computer child, with its start tab loaded at the site.browser_sign_insigns it in asalex.reset_envleaves it signed out.browser_sign_insigns it in again.shop.test.test_multi_env_computers.py): without a run override, a multi env with websites gets the config's default browser, andbrowser_envs = []still gets none.How it was tested
test_multi_env_computers.py's browser tests, 43 passed, the new one included.browser_computer_test.py -k multi_env, the five tests feat(multi): a multi env names its website browser (browser_envs), a browser computer on a sandbox of its own #598 added, passed 5 of 5 on the same VM./api/health, which this site doesn't serve. The deploy refused the 404 start tab, as designed, so it now starts at the site's/api/session.ruff checkpasses on both files.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Adds tests for a multi env that gets Chromium from the config default.
Reviews (1) · Last reviewed commit: "test(multi): under a chromium default, a..." · Reviewed by Greptile