Skip to content

test(multi): under a chromium default, a site's multi env gets chromium unnamed, which browser_sign_in signs in after each reset (FD-4961) - #617

Merged
earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-4961-m814-browser_envs-on-the-multi-env
Nov 11, 2026
Merged

earakely-scale merged 1 commit into
mainfrom
edgararakelyan/fd-4961-m814-browser_envs-on-the-multi-env

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

M8.14 (FD-4961): the default website browser is added to a multi env with sites, and signed in. #598 and M5.15 (#556) already built all of it, so this PR proves M8.14's "done when" on the code that shipped and adds no production code.

Until now the default was tested only through the run override, and sign-in only on a desktop computer carrying a browser app, never on a browser computer the multi env added itself.

What changes

Tests only:

  • Integration (browser_computer_test.py): under a config whose default website browser is the chromium computer, a multi env with a site that offers session names no browser and deploys chromium as its one computer child, with its start tab loaded at the site.
    • browser_sign_in signs it in as alex.
    • reset_env leaves it signed out.
    • A second browser_sign_in signs it in again.
    • The step's record names shop.test.
  • Unit (test_multi_env_computers.py): without a run override, a multi env with websites gets the config's default browser, and browser_envs = [] still gets none.

How it was tested

  • Unit: test_multi_env_computers.py's browser tests, 43 passed, the new one included.
  • Integration, local Docker on an agent-environments-admin amd64 VM: the new test passes. Beside it, browser_computer_test.py -k multi_env, the five tests feat(multi): a multi env names its website browser (browser_envs), a browser computer on a sandbox of its own #598 added, passed 5 of 5 on the same VM.
    • The test's first run started chromium at /api/health, which this site doesn't serve. The deploy refused the 404 start tab, as designed, so it now starts at the site's /api/session.
  • ruff check passes on both files.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Adds tests for a multi env that gets Chromium from the config default.

  • Tests cover default-browser sign-in across resets.

Reviews (1) · Last reviewed commit: "test(multi): under a chromium default, a..." · Reviewed by Greptile

…um unnamed, which browser_sign_in signs in after each reset

M8.14's done-when, on the code #598 and M5.15 shipped: with the config's
default website browser the chromium computer, a multi env with a site that
offers session names no browser and deploys chromium as its computer child;
browser_sign_in signs it in, reset_env leaves it signed out, and a second
browser_sign_in signs it in again. A unit test covers the config's default
beside the run's override.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale requested a review from a team as a code owner November 11, 2026 16:48
@earakely-scale
earakely-scale merged commit 75f03d9 into main Nov 11, 2026
75 of 88 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-4961-m814-browser_envs-on-the-multi-env branch November 11, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant