Skip to content

fix(ci): the durations refresh keeps the times of a tier the run skipped - #623

Open
andrewpark-scaleai wants to merge 1 commit into
mainfrom
andrewpark/durations-keep-skipped-tiers
Open

andrewpark-scaleai wants to merge 1 commit into
mainfrom
andrewpark/durations-keep-skipped-tiers

Conversation

@andrewpark-scaleai

@andrewpark-scaleai andrewpark-scaleai commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Why

The goal is faster agentenv-framework CI with no test weakened. The shard tables are rebuilt from a run's JUnit reports with .github/scripts/slow_test_durations.py, and the script rewrites the table whole. When a run skips a tier, as main's run 43079720062 skipped the installer tier, every unit of that tier drops out of the table. Those shards then balance by the median, not by real times.

What

  • The script keeps a file's old seconds when the reports have no test from that file and the file still exists. A deleted file is still dropped. A file that the reports cover still loses tests that were renamed.
  • test_a_file_the_reports_have_no_test_of_keeps_its_times fails on main's script and passes with this change.
  • test_a_reported_split_file_drops_its_tests_the_reports_dont_have pins the renamed-test behaviour.

Verification

  • On run 43079720062's reports, main's script keeps 0 of the 59 installer units, and this one keeps all 59.
  • tst/unit/test_slow_test_durations_script.py passes, 5 tests.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Keeps saved test times for existing files absent from the supplied JUnit reports.

  • The duration refresh keeps times for unreported test files that still exist.

No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(ci): the durations refresh keeps the..." · Reviewed by Greptile

@andrewpark-scaleai
andrewpark-scaleai requested a review from a team as a code owner November 11, 2026 20:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant