Repository navigation
ci: pull the base images at once - #624
Open
andrewpark-scaleai wants to merge 1 commit into
Open
andrewpark-scaleai wants to merge 1 commit into
andrewpark-scaleai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The goal is faster agentenv-framework CI with no test weakened. Each Docker shard runs
mirror_base_images.py, which pulls its 9 base images one after another. In CI that takes 25s, and the slowest single pull takes 5s. It runs on every Docker shard, including the slow tier's longest.What
mirror_base_images.pypulls all the bases at the same time. It still switches dockerd to the containerd store first, and each image keeps its own retries and tag.test_the_bases_are_pulled_at_onceholds both fake pulls at a barrier. It fails on main's serial code (BrokenBarrierError) and passes with this change.Expected effect
About 15s off every Docker shard. That's an estimate from the CI step times. This PR's own run will show the measured time.
Verification
tst/unit/test_mirror_base_images_script.pypasses, 10 tests.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
mirror_base_images.pynow pulls base images concurrently.Reviews (1) · Last reviewed commit: "ci: pull the base images from mirror.gcr..." · Reviewed by Greptile