Repository navigation
feat(rubrics_verifier): fail_task_when_not_passing fails the task on a verdict that isn't passing - #640
Open
earakely-scale wants to merge 1 commit into
Open
feat(rubrics_verifier): fail_task_when_not_passing fails the task on a verdict that isn't passing#640earakely-scale wants to merge 1 commit into
earakely-scale wants to merge 1 commit into
Conversation
…a verdict that isn't passing A rubrics_verifier with fail_task_when_not_passing set fails its step with VerifierNotPassingError when its recorded verdict scores below 1.0, after the verdict is written; the score itself is computed as before. The option is refused with fail_task_on_error false, since a tolerated failure lets the steps after it score the run. The scheduler does not retry a VerifierNotPassingError under retry_config: grading the same run again could pass it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Some tasks run a verifier that checks whether the run was a fair test at all: whether the scripted events fired, whether colleagues stayed on script, whether the solver stayed out of the harness. Today that verifier records its verdict, but nothing acts on it, so a run that fails the check still reports its quality score.
What changes
rubrics_verifier.fail_task_when_not_passing: truefails the step withVerifierNotPassingErrorwhen the recorded verdict isn't passing, once the verdict has been written.score_aggregator.fail_task_on_error: false, because a tolerated failure would let the steps after it run and score the run.VerifierNotPassingErrorunderretry_config: grading the same run again could pass it.VerifierNotPassingErrorsits inagent_env.task_step.context, next toStepContextError, and is exported fromagent_env.task_step.With the option set, and the scoring step depending on the verifier, a run that fails the check ends FAILED before anything scores it. Consumers that already drop failed runs then drop it too:
{"id": "validity", "type": "rubrics_verifier", "fail_task_when_not_passing": true, "...": "..."}, {"id": "final-score", "type": "aggregate_verifiers", "verifier_ids": ["rubric-judge"], "depends_on": ["rubric-judge", "validity"]}Docs. The step reference should document
fail_task_when_not_passing: what passing means, thefail_task_on_errorrequirement, and that the scoring step should depend on the verifier.How it was tested
Unit tests:
tst/unit/task_step/verifiers/test_rubrics_verifier_fail_task_when_not_passing.py(10 tests) covers:fail_task_on_error: false;retry_confignot grading the run again: three gradings without the scheduler change, one with it.tst/unit/task_step,tst/unit/task,tst/unit/bundleandtst/unit/runnerpass: 4,038 passed, 11 skipped.End to end: in progress; results will be added here.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
Adds an opt-in gate that fails a task after a rubric verifier records a score below 1.0.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Grade run] --> B[Record verdict] B --> C{Gate enabled and score below 1?} C -- No --> D[Complete verifier] D --> E[Release dependent steps] C -- Yes --> F[Raise VerifierNotPassingError] F --> G[Skip scheduler retry] G --> H[Save failed task and verdict]Reviews (1) · Last reviewed commit: "feat(rubrics_verifier): fail_task_when_n..." · Reviewed by Greptile