Skip to content

fix: phase 5 issues #40 - #46

Merged
berntpopp merged 3 commits into
mainfrom
fix/phase5
Oct 16, 2026
Merged

berntpopp merged 3 commits into
mainfrom
fix/phase5

Conversation

@berntpopp

Copy link
Copy Markdown
Member

Fixes #40

🤖 Gemini 4 Argon; reviewed by Codex GPT-6 Astra; adjudicated by Argon.

berntpopp and others added 2 commits October 16, 2026 07:46
…ile/launcher stage-safe

Use Python 3.11 with snakemake in CI to execute dry-run and schema tests. Guard default configfile loading in Snakefile, fall back cleanly when resources.mem_mb is unset outside the repo dir, and resolve REPO_ROOT and conditional conda activation in run_snakemake.sh.

Fixes #40

Co-Authored-By: Gemini 4 Argon <noreply@google.com>
Guard default configfile loading with workflow.overwrite_configfiles so CLI --config overrides retain default config.

Co-Authored-By: Gemini 4 Argon <noreply@google.com>
@berntpopp

Copy link
Copy Markdown
Member Author

Final adjudication of the Codex review (Gemini 4 Argon, ponytail): approve

Replaced if not config: with if not workflow.overwrite_configfiles: in workflow/Snakefile so CLI --config overrides preserve config/config.yaml defaults while external --configfile runs remain isolated, and added a regression test in tests/test_dryrun.py.

Finding Decision Reason
workflow/Snakefile:11 CLI --config override suppresses default configfile valid-fix-now Guarded default configfile with if not workflow.overwrite_configfiles: so CLI-only --config overrides still merge onto config/config.yaml while --configfile staging invocations skip the repo default; added CLI override regression assertion.

Tests: 131 passed (pytest including dry-run and schema tests), ruff check, ruff format --check, snakefmt --check, bash -n scripts/run_snakemake.sh

Co-Authored-By: Gemini 4 Argon <noreply@google.com>
@berntpopp
berntpopp merged commit 6be7863 into main Oct 16, 2026
2 checks passed
@berntpopp
berntpopp deleted the fix/phase5 branch October 18, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(ci): run Snakemake dry-run and schema tests in CI and make Snakefile/launcher stage-safe

1 participant