Skip to content

Provide alternative URL benchmarks not affected by cache savings - #262

Merged
AdrianAtZyte merged 1 commit into
scrapy:masterfrom
AdrianAtZyte:benchmark-improvements
Jun 10, 2026
Merged

AdrianAtZyte merged 1 commit into
scrapy:masterfrom
AdrianAtZyte:benchmark-improvements

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Contributor

I believe the cache is hiding the gains from #261.

@AdrianAtZyte
AdrianAtZyte requested a review from wRAR June 10, 2026 10:53
@codecov

codecov Bot commented Jun 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.70%. Comparing base (d1c393e) to head (381ad02).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files           9        9           
  Lines         848      848           
  Branches      172      172           
=======================================
  Hits          837      837           
  Misses          4        4           
  Partials        7        7           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 32 untouched benchmarks
🆕 13 new benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
🆕 test_benchmark_url_cold[add_or_replace_parameter] N/A 746.9 µs N/A
🆕 test_benchmark_url_cold[add_or_replace_parameters] N/A 328.4 µs N/A
🆕 test_benchmark_url_cold[any_to_uri] N/A 181.3 µs N/A
🆕 test_benchmark_url_cold[canonicalize_url] N/A 350.2 µs N/A
🆕 test_benchmark_url_cold[file_uri_to_path] N/A 126.4 µs N/A
🆕 test_benchmark_url_cold[is_url] N/A 23.2 µs N/A
🆕 test_benchmark_url_cold[parse_data_uri] N/A 607.2 µs N/A
🆕 test_benchmark_url_cold[parse_url] N/A 145.9 µs N/A
🆕 test_benchmark_url_cold[path_to_file_uri] N/A 162 µs N/A
🆕 test_benchmark_url_cold[safe_download_url] N/A 392.5 µs N/A
🆕 test_benchmark_url_cold[safe_url_string] N/A 1.9 ms N/A
🆕 test_benchmark_url_cold[url_query_cleaner] N/A 155.5 µs N/A
🆕 test_benchmark_url_cold[url_query_parameter] N/A 124.1 µs N/A

Comparing AdrianAtZyte:benchmark-improvements (381ad02) with master (d1c393e)

Open in CodSpeed

@AdrianAtZyte
AdrianAtZyte merged commit d5877fe into scrapy:master Jun 10, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants