-
Notifications
You must be signed in to change notification settings - Fork 2
External images can have only one architecture #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divolgin
wants to merge
1
commit into
main
Choose a base branch
from
divolgin/404-is-not-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| package listener | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestClassifySbomDownloadFailureSkipsUnsupportedPlatforms(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| stderr string | ||
| }{ | ||
| { | ||
| name: "mismatched single-platform image", | ||
| stderr: `ERROR could not determine source: | ||
| - oci-registry: mismatched platform (expected linux/amd64): image platform="linux/arm64/v8" does not match user specified platform="linux/amd64" | ||
| - oci-model: unexpected status code 401 Unauthorized`, | ||
| }, | ||
| { | ||
| name: "manifest has no matching platform", | ||
| stderr: "no match for platform in manifest: not found", | ||
| }, | ||
| { | ||
| name: "platform image not found", | ||
| stderr: "no image found for platform linux/arm64", | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| failure, skipped := classifySbomDownloadFailure(1, tt.stderr) | ||
| if !skipped { | ||
| t.Fatal("expected unsupported platform to be skipped") | ||
| } | ||
| if failure != nil { | ||
| t.Fatalf("expected no failure for skipped platform, got %v", failure) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestClassifySbomDownloadFailurePreservesRealErrors(t *testing.T) { | ||
| stderr := "unexpected status code 401 Unauthorized: Not Authorized" | ||
| failure, skipped := classifySbomDownloadFailure(1, stderr) | ||
| if skipped { | ||
| t.Fatal("expected authentication error not to be skipped") | ||
| } | ||
| if failure == nil { | ||
| t.Fatal("expected authentication error to be returned") | ||
| } | ||
| if !strings.Contains(failure.Error(), stderr) { | ||
| t.Fatalf("expected failure to contain stderr, got %v", failure) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When Syft reports a platform mismatch for one source and a genuine registry error such as
401 Unauthorizedfor another source in the same stderr output, this substring match classifies the entire result as an unsupported architecture. This replaces the authentication failure with a misleading no-supported-architecture failure, or discards it entirely when another architecture succeeds.Knowledge Base Used: Build Queue and Vulnerability Scanning