Repository navigation
[UIK-6018][d3-chart] init reference area - #3243
Open
ilyabrower wants to merge 11 commits into
Open
ilyabrower wants to merge 11 commits into
ilyabrower wants to merge 11 commits into
Conversation
j-mnizhek
approved these changes
Oct 19, 2026
j-mnizhek
left a comment
j-mnizhek
left a comment
Member
There was a problem hiding this comment.
Super!
Updated:
- gradients to match the design
- position for titles for these highlighted areas
| }; | ||
|
|
||
| /** | ||
| * @deprecated use `referenceArea` property on Chart.Line. |
Contributor
There was a problem hiding this comment.
maybe referenceLine instead of referenceArea? @ilyabrower
| */ | ||
| Title: IntergalacticD3Component<'text', ReferenceLineTitleProps, Context>; | ||
| /** | ||
| * @deprecated use `ReferenceBackground` instead. |
Contributor
There was a problem hiding this comment.
@ilyabrower as i understood ReferenceBackground is deprecated too (lines 73-75), so we should write here something else
| Context | ||
| > & { | ||
| /** | ||
| * @deprecated use `referenceArea` property on Chart.Line with title propertry |
Contributor
There was a problem hiding this comment.
Suggested change
| * @deprecated use `referenceArea` property on Chart.Line with title propertry | |
| * @deprecated use `referenceArea` property on Chart.Line with title property |
Contributor
|
@ilyabrower maybe add info about deprecated use in changelog? |
…e value, fixed ui rudiment in line withour area
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/d3-chart
Changed
Reference*components in Charts.Added
referenceLineandreferenceAreaproperties to theChart.Line.Motivation and Context
How has this been tested?
I've added new args to the base-example in Chart.Line test story.
Screenshots (if appropriate):
Types of changes
Checklist: