Fix panic due to string slicing at char boundary - #3025
ginnyTheCat wants to merge 1 commit into
Conversation
|
The |
|
I'm confused what transformations you would want to apply to a empty string? But yes, I'm open to a adding a test case ofc once I better understand your intentions. |
|
The implementation mirrors |
|
Apologies — the previous comment was accidentally posted to the wrong PR. To continue the thread on this PR: consider the case where a struct field is renamed via |
c9a3e34 to
ec96fb7
Compare
This is a alternative solution to fix #2953 than #3024 by continuing to just support ASCII but not panic in this unwanted case.
Since this only makes code that didn't compile before compile now I would not consider this a breaking change.