Repository navigation
feat(ui): compact device header; collapsible, consistent Device section - #238
Merged
Merged
Conversation
- Device details bar is 36px (was ~61px), aligned with the traffic lights like the list view's 34px title bar: 28px back button, smaller header icons, long device names ellipsize. - The Device section now uses the EdgeView Session structure (section title row, bordered card, status grid) and is collapsible, collapsed by default with a one-line summary (EVE, uptime, CPU, memory); the choice is remembered per viewer. Items keep a label + value + one sub-line rhythm and never wrap; detail moves into tooltips. - EVE version drops the platform suffix (kvm-amd64 etc.) from the value; partition and the other partition's version move to the tooltip, with a small "update pending" hint only when relevant. - The separate Workloads list is gone: each Running Applications row shows its own CPU and memory, matched by app id. Device info is fetched once per device by a useDeviceInfo hook shared by both. Signed-off-by: sergey-zededa <sergey@zededa.com>
Wrapping tooltips were positioned inside their trigger without a width, so they shrank to the trigger (often a short label like ENCRYPTION), stacking one or two words per line and scrolling. They now size to their text up to 320px (within the window). The Encryption and Sessions tooltips are rewritten short: a heading line, then one or two sentences. Signed-off-by: sergey-zededa <sergey@zededa.com>
…ner scroll for normal text Signed-off-by: sergey-zededa <sergey@zededa.com>
- Placement checked overflow against the window only, but inline
tooltips are clipped by scrolling ancestors such as the device details
pane, which starts below the title bar: a tooltip near the top of the
pane fit the window and was cut off. Flip and horizontal shift now use
the window narrowed by every clipping ancestor (visibleBounds), and
when neither side fits the roomier one is used.
- The help-link variant reset white-space to normal, collapsing the
text's line breaks ("Slot 1: free Slot 2: free"); it now keeps them.
Signed-off-by: sergey-zededa <sergey@zededa.com>
Device info and device configuration now share one "Device" section, placed below EdgeView Session where users already expect the device settings: - EdgeView Session keeps its status grid and management IPs plus an EDGEVIEW actions row with the two EdgeView-specific controls, Enable Ext. Policy (EdgeView policy; the denial toast still flags it) and Collect Info (live session). - Device: the title row with the summary toggles only the facts grid (collapsed by default); the CONFIGURATION chips (SSH key, VGA, USB, Console) and Authorized SSH Keys are always visible, still usable offline, and don't wait on the facts loading. - The External Policy denial message now points to the EdgeView Session section instead of the former "Device Configuration below". Signed-off-by: sergey-zededa <sergey@zededa.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #236 after looking at it in the app.
Header
The device details bar is now 36px, down from about 61px. Like the list view's 34px title bar, it sits level with the macOS traffic lights.
Device section
It now has the same structure as EdgeView Session: a title row, a bordered card and a status grid.
EVE 14.5.2-lts · up 7h 29m · CPU 3.0% · Mem 2.6/7.6 GB. Expanded or collapsed is remembered per viewer.14.5.2-lts.IMGA.No duplicate workloads
The separate Workloads list is removed. Each Running Applications row shows its own
CPU x% · used / allocatedafter the compose badges, matched by app id. A newuseDeviceInfohook fetches device info once per device for both places.Testing
npm test -- --run: 184 passed. One full run first showed a timing flake in an unrelated existing test, "removes an unparseable line by its raw text"; it passed on rerun and when run alone.npm run buildpasses.🤖 Generated with Claude Code