Repository navigation
Conversation
… flow-map scans - SCAN_PATTERN and stripComments now consume '''...''' and """..." literals whole; a triple-quoted string quoting import text no longer invents a dependency (Devin Review on #72). - findFlowMappingEnd and parseFlowSourceDirective skip YAML comments: a '}' inside a comment between flow-map members no longer closes the map early and the comment text no longer reads as an unreadable member. - DEPLOYMENT.md now describes the merged scoped-skip + approximation policy instead of the dropped graph-level skip. - server.dart: drop the duplicated maxDependenciesPerRequest check whose second branch was unreachable and hardcoded the wrong field name. Co-Authored-By: Stuart Gardoll <sgardoll@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Contributor
|
This PR does not match any of the 1 configured review trigger rule. |
Contributor
Author
sgardoll
merged commit Sep 28, 2026
f1c819d
into
milestone/stu-implement-updated-ui-ux
2 checks passed
sgardoll
pushed a commit
that referenced
this pull request
Sep 28, 2026
…u445-exact-html-fidelity Re-sync STU-445 onto base f1c819d (merges #108 -> #104 -> #103). Single conflict, in index.html, comment-only: the base adds a five-line comment above <div class="pipeline-view"> documenting #104's initPipelinePanelOrder focus-order contract. Resolved by taking the base side's comment. The base's #104 CSS changes (dropping grid-template-areas in favour of JS-driven region ordering) auto-merge and are preserved. dist/ regenerated from the merged sources: app.js differs from both parents, so the previous bundle was pre-merge. index-CD_p5Yhb.js -> index-C31N1DOp.js. CSS is byte-identical (index-BQUorxWE.css), and a second build is a no-op. npm test 388/388 green (the base contributes 3 tests over the prior 385). No test changed, skipped, or weakened by this merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the four Devin Review findings posted on the merged PR #72 commit (6ebe6e9).
Phantom dependencies from multiline Dart strings (
dartPackageImports.js).'''/"""literals were not consumed as tokens, soimport 'package:x/x.dart';inside a triple-quoted string scanned as a real directive and could addxto the project's pubspec.STRING_PATTERNnow lists triple-quoted alternatives first (a'/"literal cannot span lines, so without them the string's interior lines scan as directives), andstripCommentsmatchescode.slice(i, i+3)before falling back to a single-char quote. Raw variants (r'''...''') are covered — theris output bare and the quotes consume normally.Comment braces closing flow maps early (
pubspecSync.js).findFlowMappingEndcounted}inside YAML comments, so{+# close } later+sdk: flutter+}truncated at the comment's}and classified an SDK package unrepresentable. BothfindFlowMappingEndandparseFlowSourceDirectivenow honor the YAML comment rule (a#preceded by whitespace runs to end of line); the member segmenter excises comment text into a cleaned string before splitting, so a comment line can't masquerade as an unreadable member.DEPLOYMENT.md policy drift. The verification section still described the dropped conservative policy ("any class importing a
package:URI is reported unverified"). Rewritten to the merged semantics: direct importers of an unreproducible dep are reported with a reason; every other class compiles against the reduced scratch graph with one approximation notice per missing package;dart:-only classes are unaffected.server.dart. Removed the second
value.length > maxDependenciesPerRequestcheck in_normalizeSdkPackages— unreachable, and its hardcodedsdkPackagesmessage was wrong for thesdkOverridescall site anyway.Tests
'''string quoting an import + a real import after it; raw"""variant; multiline flow map with}in a comment.npm test386/386,test:deploy-guard9/9,test:proxies30/30,npm run buildclean.dist/rebuild in this PR per repo convention.Link to Devin session: https://app.devin.ai/sessions/616e9d5ba84144cfb7168de3eed8da26
Open in Devin Desktop: https://app.devin.ai/desktop/session/616e9d5ba84144cfb7168de3eed8da26?variant=devin
Requested by: @sgardoll