Repository navigation
Fix flaky stu376 demo-window catch: budget must cover page init + the 5.2s hold - #110
Merged
sgardoll merged 1 commit intoSep 28, 2026
Conversation
…init The demo-window catches raced the demo's real-time clock: an 8s deadline against a ~5.2s hold left <3s for page init on a loaded worker, so the 'a live reduced-motion flip mid-demo' spec timed out before the typing window opened. Raise the shared catch budget to 20s — it covers init plus the hold while still ending before the demo could finish, and leaves every assertion unchanged. Co-Authored-By: Stuart Gardoll <sgardoll@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Contributor
|
This PR does not match any of the 1 configured review trigger rule. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
sgardoll
merged commit Sep 28, 2026
3ed7dd8
into
milestone/stu-implement-updated-ui-ux
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e2e/stu376-composer.spec.js's STU-445 demo-window catches raced the hero demo's real-time clock — the same harness-race class PR #105 fixed for stu385.Each catch waits on
waitForFunction(is-demo-typing && 0 < prefix < N)with a fixed 8s deadline, but the demo holdsHERO_DEMO_HOLD_MS(~5.2s) before its first character lands. That leaves under ~3s of slack for page init on a loaded worker; when init is slow the typing window opens after the deadline and the catch times out. Observed locally:a live reduced-motion flip mid-demo stops the typing and restores the promptfailed its initial attempt withpage.waitForFunction: Timeout 8000ms exceeded, then passed on retry.Fix: one shared
DEMO_CATCH_TIMEOUT_MS = 20000replaces the seven identical{ timeout: 8000 }catch options. The budget now covers page init plus the hold while still ending before the demo could finish; no assertion was loosened — the flip-restore check keeps its own 1stoHaveValuedeadline, and the prefix-window predicates are unchanged.Verified:
CI=1 CCC_TEST_PORT=3105 npx playwright test e2e/stu376-composer.spec.js→ 28 passed (previously 27 passed / 1 flaky).Link to Devin session: https://app.devin.ai/sessions/90257fc9a4564d719aaf06102f872441
Open in Devin Desktop: https://app.devin.ai/desktop/session/90257fc9a4564d719aaf06102f872441?variant=devin
Requested by: @sgardoll