Repository navigation
test(e2e): cover the slow-runner timeout and reconcile message - #112
Conversation
The 840s UI bound keeps the live progress view alive on routine deploys, but when a provision response is still lost or expired the app re-reads the project and reports which classes actually landed instead of leaving the user on a dead-end. These browser tests drive the real provisioning transport against a stalled mocked runner at a millisecond bound and render the reconcile outcome through the real terminal renderer, locking in that the timeout is UNCONFIRMED — never a fabricated failure — and that the modal names the project and a next step.
|
This PR does not match any of the 1 configured review trigger rule. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| await page.route("**/exportCode", async (route) => { | ||
| await route.fulfill({ | ||
| status: 200, | ||
| contentType: "application/json", | ||
| body: JSON.stringify({ | ||
| value: { project_zip: await projectZipWithClassLanded() }, | ||
| }), | ||
| }); | ||
| }); |
There was a problem hiding this comment.
🔍 Reconciliation fixture skips the initial project state
The export always contains GaugeModel, while the hook receives no remoteFiles. A real deploy reads that export first and skips provisioning an existing class. Model the class appearing after the stalled request to exercise the claimed journey.
Was this helpful? React with 👍 or 👎 to provide feedback.
| window.__CCC_RENDER_DEPLOY_TERMINAL__({ | ||
| success: false, | ||
| unconfirmed: true, | ||
| targetIdentity, | ||
| error: message, | ||
| }); |
There was a problem hiding this comment.
🔍 Timeout outcome does not drive modal classification
The test supplies unconfirmed: true rather than deriving it from the caught error. A broken production error-to-result mapping can still leave this modal test passing.
Was this helpful? React with 👍 or 👎 to provide feedback.
What
Adds e2e/deploy-timeout-reconcile.spec.js covering: a provisioning that outlives the UI bound is UNCONFIRMED (never a fabricated failure), and after the bound the reconcile re-read reports which classes actually landed instead of a dead-end 'go check yourself'.
Why
Commit 5231e76 raised the deploy UI bound to 840s and added reconcileUnconfirmedProvision, which re-reads the project and reports what landed. These browser tests lock that behavior in: the timeout path stays reachable in test time by stalling the mocked runner and shortening the bound to milliseconds (not 840 real seconds), and the reconcile message is rendered through the real
__CCC_RENDER_DEPLOY_TERMINAL__entry point.Tests
npx playwright test deploy-timeout-reconcile.spec.js— 2 passed.node --test src/*.test.js— 399 passed.npx playwright test stu380-deploy.spec.js— runs, but 6 pre-existing failures: stu380's project-source-cache tests countexportCallsand were not updated for the new reconcile re-read that commit 5231e76 introduced (reconcile now makes an extraexportCodecall on unconfirmed provisioning). Those tests/semantics are owned by the app.js workstream; I did not touch them.