Repository navigation
fix(e2e/stu380): account for the reconcile re-read in transport outcome counts - #117
Merged
sgardoll merged 1 commit intoOct 4, 2026
Conversation
…me counts Commit 5231e76 made every unconfirmed provision perform one extra project export (reconcileUnconfirmedProvision) to report what actually landed. Six STU-380 transport regression tests counted project exports with exact 'expect(exportCalls).toBe(N)' assertions and were each off by one (or, for the 502 test, still asserted the pre-reconcile message). Update them: - Every count after an unconfirmed provision shifts by the one reconcile re-read; confirmed/success paths add no read, so multi-provision tests (1171, 1282) shift by exactly one, not by one per provision. - The gateway-502 test now asserts the reconcile message (name of the re-read result and the re-read-before-retry advice) instead of the raw 'HTTP 502', while keeping the no-fabricated-'dropped' guard. Proved the tests still bite: with the reconcile read stubbed to a no-op in a scratch copy, exactly these six tests fail (31 passed / 6 failed); the expectations depend on the reconcile read, so removing it fails them. app.js is untouched. Full e2e suite green (262 passed).
Contributor
|
This PR does not match any of the 1 configured review trigger rule. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Commit 5231e76 made every
unconfirmedprovision perform one extra project export (reconcileUnconfirmedProvision) so the deploy can report what actually landed. Six STU-380 transport-outcome regression tests count project exports with exactexpect(exportCalls).toBe(N)assertions, so each was off by one (and the gateway-502 test still asserted the pre-reconcile message). Result: 31 passed / 6 failed.Fix (test-only, app.js untouched):
Proved the tests still bite: with the reconcile read stubbed to a no-op in a scratch copy, exactly these six tests fail (31 passed / 6 failed). The expectations depend on the reconcile read, so removing it fails them. Reverted the stub; app.js is untouched.
Verification:
npx playwright test e2e/stu380-deploy.spec.js→ 37 passed. Full suite (npx playwright test) → 262 passed.