Repository navigation
fix(canary): give the dry-run a timeout a real deploy can finish inside - #122
Merged
Merged
Conversation
The canary bounded its request at 60s. A real deploy takes 103-215s, and the canary drives that same path, so every scheduled run would have failed with "timed out" - a daily false alarm, which is worse than no canary because it trains you to ignore it. 300s sits above the slowest observed deploy and below Cloud Run's 900s request cap. Verified against the live runner: at 60s it fails, at 400s it reports OK and reads the health route.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
The canary bounded its request to the runner at 60s. A real deploy takes 103-215s on the production runner, and the canary drives the same path — so every scheduled run would have failed with
request ... failed: timed out.A daily job that always fails is worse than no job: it trains you to ignore it, and the real failure it exists to catch looks identical.
Verified against the live runner
The fix
Default is now 300s — above the slowest observed deploy (215s), below Cloud Run's 900s request cap.
CANARY_TIMEOUT_MSstill overrides it.Found by actually running the canary against production rather than trusting that it had been reviewed.