Repository navigation
Conversation
STU-368. Which packages the Flutter SDK supplies was decided by a hand-maintained name list kept in three places, and flutter_web_plugins was in none of them. Every project declaring it - which is every web-enabled project with a plugin - read it as a dependency that could not be reproduced, and the deploy was refused for a package most of its classes never imported. The project's own pubspec already says where each package comes from; the parser read those lines and threw them away. It now returns them as sourceKey/sourceValue, so the classification is exact and cannot fall behind the SDK: sdk: -> the Flutter SDK, reproduced from the name a nested version: -> a constraint written on its own line git: / path: / nested hosted: -> not expressible in the manifest SDK_DEPENDENCIES is gone. The runner's allowedSdkPackages is gone too - it independently refused the same deploy with 'Unsupported SDK package'. That allowlist was also the only validation of an sdkPackages entry, so the package name pattern now does that job; without the swap a caller-supplied name would reach the generated pubspec unchecked. The runner still writes 'sdk: flutter' itself, so that value never comes from a caller. Refusal is now scoped per class, to that class's own imports, so one git: entry no longer leaves an entire deploy uncompiled. The accept/warn split already existed and is unchanged: a real analyzer error refuses with 422, and a class that could not be compiled is pushed with its warning logged before the provisioning request. Corrects DEPLOYMENT.md, which still described the scaffolding-closure compilation that reverting a1238f0 removed, and still claimed that nothing unverified is deployed. Verified: 274/274 tests, deploy guard 9/9, proxies 30/30, build clean, dart analyze on the runner reports no issues.
- Add src/designTokens.css as the single shipping token stylesheet, extracted from the canonical custom-code-connect-hero.html :root token set. - Link the stylesheet from index.html; reuse existing /fonts/Delight-VF.ttf and DM Mono Google Fonts path. - Replace the legacy inline :root in index.html with only the layout constant --sidebar-w, preserved until its owning shell change. - Migrate legacy variable references to new tokens: --main-bg -> --bg, --navy -> --fg, --label -> --muted, --sublabel -> --muted-2, --input-bg -> --surface-sunken, --input-border -> --border, --badge-bg -> --accent-soft, --badge-text -> --accent, --glow-color -> --accent-soft. - Centralize :focus-visible and prefers-reduced-motion defaults in the token stylesheet and remove redundant local reduced-motion rules. - No generation/deploy code changed; app.js has no affected CSS var refs.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
…ust the first (cherry picked from commit d5a3c92)
…can reach a class transitively (cherry picked from commit 9d338ad)
…hape (cherry picked from commit ff9bfac)
(cherry picked from commit 1ed78b6)
…t HTML (cherry picked from commit ece1237)
… scratch-graph approximation (cherry picked from commit e300b76)
Owner
Author
|
@greptileai — all findings from the previous review have been addressed (see new commits). Please re-review this PR. |
Owner
Author
|
Closing: this branch is already fully contained in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes STU-374.
What this PR does
src/sharedControls.jsandsrc/sharedControls.csswith shared button, icon-button, field, badge, panel and dialog states.app.jswhile preserving their calling contracts and adds non-dismissable pending behavior for commit progress.scripts/test-accessible-modals.mjsandnpm run test:accessibilityto cover all seven adapted shells.Verification
npm test— 274/274 passing.npm run build— production bundle built successfully.npm run test:accessibility— passed for 7 shells at 360×500, verifying focus containment/return, Escape, pending blocking, keypress isolation, 44px touch targets and small-height scrolling.git diff --check— clean.The PR appears safe to merge, with no outstanding findings in the current revision.
Summary
This PR introduces shared accessible controls and modal lifecycle management, adapts existing modal entry points, expands custom-code dependency verification reporting, and adds CI coverage for accessibility and deployment safeguards.
Reviews (4) · Last reviewed commit: "fix: scope the verification skip to dire..."