Repository navigation
✅ Cover getCommittedOpVersion deterministically - #187
Merged
Merged
Conversation
At the moment, Coveralls swings by 0.8% between runs of identical code: #186 only touches `package.json`, but still lost coverage. The only test that reaches the found-op path of `getCommittedOpVersion` is sharedb's "does not fail when resubmitting a create op", and only when it wins a race: about once in 60 suite runs. This change tests `getCommittedOpVersion` directly, including its bounded read from the earliest matching op. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
coverage: 94.636% (+1.0%) from 93.683% — test-committed-op-version into main |
alecgibson
marked this pull request as ready for review
October 22, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, Coveralls swings by 0.8% between runs of identical code: #186 only touches
package.json, but still lost coverage.The only test that reaches the found-op path of
getCommittedOpVersionis sharedb's "does not fail when resubmitting a create op", and only when it wins a race: about once in 60 suite runs.This change tests
getCommittedOpVersiondirectly, including its bounded read from the earliest matching op.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com