Skip to content

fix: trigger releases for version tags - #6

Merged
sharingan2077 merged 1 commit into
mainfrom
fix/release-tag-trigger
Aug 13, 2026
Merged

sharingan2077 merged 1 commit into
mainfrom
fix/release-tag-trigger

Conversation

@sharingan2077

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings August 13, 2026 21:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow so releases can be triggered both automatically from version tags and manually via workflow_dispatch, enabling re-publishing an existing tag.

Changes:

  • Fix tag trigger pattern for push events ("v*").
  • Add workflow_dispatch input (tag) to publish an existing version tag manually.
  • Use the selected tag/ref when checking out code and naming release assets.
Suppressed comments (3)

.github/workflows/release.yml:27

  • ref: ${{ inputs.tag || github.ref }} will fail on the push trigger because the inputs context doesn't exist outside workflow_dispatch/workflow_call. Use an event-name guard so tag pushes can still run.
        with:
          fetch-depth: 0
          ref: ${{ inputs.tag || github.ref }}

.github/workflows/release.yml:49

  • This workflow runs on push as well as workflow_dispatch, but inputs.tag is referenced directly. On push runs the inputs context is undefined and the expression will error. Guard the inputs access with github.event_name.
      - name: Prepare release assets
        env:
          TAG: ${{ inputs.tag || github.ref_name }}
        run: |

.github/workflows/release.yml:56

  • TAG: ${{ inputs.tag || github.ref_name }} will fail for the push trigger because the inputs context doesn't exist there. Guard it with github.event_name == 'workflow_dispatch' so tag pushes can still create releases.
        env:
          GH_TOKEN: ${{ github.token }}
          TAG: ${{ inputs.tag || github.ref_name }}
        run: gh release create "$TAG" "CashEye-${TAG}.apk" "CashEye-${TAG}.apk.sha256" --generate-notes --title "CashEye $TAG"

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 16 to 18
concurrency:
group: release-${{ github.ref }}
group: release-${{ inputs.tag || github.ref }}
cancel-in-progress: false
@sharingan2077
sharingan2077 merged commit c10ab06 into main Aug 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants