Repository navigation
The lint and format rules are @formancy/code-style 0.12.0, pinned exactly, in place of the copy - #143
Merged
Merged
Conversation
… rules are about to be pinned
…ctly, in place of the copy
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The lint and format rules are now
@formancy/code-style0.12.0, pinned exactly as a root devDependency, in place of the copy atscripts/code-style/(0116, 0002).eslint.config.mjs,prettier.config.mjs,scripts/lint.test.mjs,scripts/prettier-merge.mjsand its test import the package. Inprettier-merge.mjsonly the import line changed, so Report's identical copy takes the same one-line change.scripts/code-style/(module and test) is deleted; its test now runs in formancy.ai's package suite.scripts/upstream-deps.mjsreads the root manifest too, test first: the new case (a^0.12.0in a root devDependency is refused) was watched failing against the old script, then passing.globals,eslint-plugin-react-hooksand@eslint-community/eslint-plugin-eslint-commentsare removed (only the copy imported them; the package brings them).@eslint/jsandtypescript-eslintstay becausescripts/lint.test.mjsimports them itself.pnpm-workspace.yamlexempts@formancy/code-style@0.12.0from the minimum release age, as for the other releases of the day.No rule changed
formancy 0.12.0's module is byte-identical to the copy it replaces (checked with
cmpon 2026-10-31). Nothing was reformatted.Ran locally
pnpm install --frozen-lockfile,pnpm build,pnpm typecheck,pnpm lint,pnpm format:check(afterpnpm formattwice),pnpm check:pkg,scripts/verify-licenses.mjs,scripts/upstream-deps.mjs, andpnpm test:repowith and withoutCI=true. Locallyscripts/browsers.test.mjsfails on macOS (it also fails onorigin/main: WebKit on darwin), and somescripts/cloudflarecases time out under load but pass run alone; CI is the judge for those.Two commits (guard, then swap); it can be squashed.