Repository navigation
Prism import: keep member banners, and the system avatar and tag - #381
Merged
Merged
Conversation
A Prism headmate's header image (`profileHeaderImageData`) is its banner. The importer filed it with the font and layout settings around it as presentation and dropped it, so members came across without their banners. It now lands on `banner_url` through the same image pipeline, quota and caps as the avatar. Which image is the banner follows Prism's own resolver: the PluralKit banner when the headmate asked for it and is linked to PluralKit (cached bytes, else the cached CDN URL, else the original URL, external links policy-gated as the avatar fallback is), Prism's own image otherwise, and nothing for a header the headmate has hidden. The job report counts banners on their own. The system block's `systemAvatarData` and `systemTag` are taken too, onto empty fields only, the way the name, description and colour already were. Prism has no system banner. The PluralPort path already carried system and member banners; a test now pins the system avatar and banner restoring from a bundle.
SiteRelEnby
enabled auto-merge
November 8, 2026 19:22
`_apply_system_profile` is called directly by the internal-image-ref unit tests with its three-argument signature, and had grown an async signature with a database session so it could store the system avatar. It is synchronous again and hands the avatar base64 back instead; `run_import` runs it through the image pipeline. Same behaviour, and the helper stays testable without a stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a report that banners were missing after a Prism import.
banners_importedin the job report.systemAvatarDataandsystemTag; both were ignored. They are now filled in when the Sheaf system has none yet, the same only-empty-fields rule the name, description and colour follow. Prism has no system banner, so there is nothing to carry there.banner_asset_id). A test now pins the system avatar and banner restoring from a bundle, which had no coverage.The Prism import notes in the design docs are corrected to match.
Verification