fix(windows): make GetIpNetEntry2 optional - #186
Merged
Conversation
4 tasks
Owner
|
Thanks for the fix and the detailed testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had CI fail recently which I traced to a bump to netdev from 0.45 to 0.46.
Ref https://github.com/n0-computer/iroh/actions/runs/32749963007/job/97507327668?pr=4487
Seems like it's a well known issue in the Wine circles and
GetIpNetEntry2is stubbed out making the process fail.Apparently there's work to get it supported in the bleeding edge of Wine/Proton, but this should make it safe for older setup to work too.
I kept the change as minimal as possible.
Here's a quick matrix after testing on our CI instance after this patch
Built from this branch for
x86_64-pc-windows-gnu, run under Wine 11.0 on Linux(
Ubuntu 22.04, freshWINEPREFIX). Baseline =main(v0.46.1), unmodified.examples/default_gatewayexamples/list_interfacescargo test --lib(20 tests)Before:
After:
default_gatewaycompletes with: