fix: preserve source.input.file when retokenizing inline comments - #179
Open
jdforrester wants to merge 1 commit into
Open
fix: preserve source.input.file when retokenizing inline comments#179jdforrester wants to merge 1 commit into
jdforrester wants to merge 1 commit into
Conversation
The replacement Input built for the remainder of the file was constructed without options, so `from` was dropped and every node after an inline comment reported `source.input.file === undefined`. lib/index.js already repairs the start/end offsets the sub-tokenizer corrupts, but not `source.input`, so the missing path reached the returned AST. Input does not retain its opts, so `from` is reconstructed from `this.input.file` rather than forwarded wholesale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue # if any, does this resolve? None filed
Please check one:
This PR:
The replacement Input built for the remainder of the file was constructed without options, so
fromwas dropped and every node after an inline comment reportedsource.input.file === undefined. lib/index.js already repairs the start/end offsets the sub-tokenizer corrupts, but notsource.input, so the missing path reached the returned AST.Input does not retain its opts, so
fromis reconstructed fromthis.input.filerather than forwarded wholesale.