Repository navigation
chore: ShellIcons mark as package icon and README logo - #3
Merged
Merged
Conversation
Neither package set PackageIcon, so nuget.org showed the default icon. assets/icon.png (the brand tile, 256 px, from md-files brand/generate.py) is now packed as the icon of every packable project through Directory.Build.props. The README, which both packages ship, opens with assets/readme-logo.svg: the tile at 64 px, ink on light and paper on dark, as a Markdown image so nuget.org renders it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the ShellIcons brand mark (heart on the Shell 5×5 dot grid).
assets/icon.png(256 px ink tile) packed asPackageIconfor every packable project, fromDirectory.Build.propsassets/readme-logo.svg, a theme-aware tile that NuGet renders as MarkdownChecked:
ShellIcons.slnxandShellIcons.Maui.slnxbuild with 0 warnings, tests pass, and the Blazor and Maui nupkgs contain the icon and README.