Skip to content

fix: pre-alpha polish (Command actions, Escape on overlays, Tailwind CLI, init and update output) - #41

Merged
Shewart merged 7 commits into
mainfrom
fix/pre-alpha-polish
Oct 3, 2026
Merged

Shewart merged 7 commits into
mainfrom
fix/pre-alpha-polish

Conversation

@Shewart

@Shewart Shewart commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Bug fixes and CLI polish before 0.4.0-alpha.1.

  • SidebarProvider (CLI template): DisposeAsync only caught JSException, so after a reload or tab close the JSDisconnectedException from ShellUI.disposeSidebar was logged twice per page load. It's caught now.
  • Command runs CommandItem.Action: clicking an item or pressing Enter ran nothing; only CommandSelected fired. Command now runs Action, then raises CommandSelected. CommandPalette is built on Command and gets the same behavior.
  • Dropdown and Popover close on Escape, from the trigger or anywhere inside the open panel (package and CLI templates). Click-outside was already handled by the backdrop.
  • init --tailwind: an explicit value now skips the prompt (it was ignored in interactive mode), an unknown value fails before init changes the project, and with --yes the output says standalone is the default and how to choose npm.
  • shellui update: the summary reported every requested component as updated. It now counts updated, skipped and failed separately.
  • Missing Tailwind CLI: the standalone Build/ShellUI.targets silently skipped Tailwind when .shellui/bin had no binary (e.g. after a fresh clone), leaving a stale app.css. The build now downloads the pinned version with MSBuild's DownloadFile and warns if it can't. Applies to projects initialized from now on.

Tests

  • bUnit tests for Command running Action before CommandSelected, and Escape on Dropdown and Popover.
  • The generated Build/ShellUI.targets parses as XML and pins the Tailwind version (standalone and npm).

Verification

  • dotnet build 0 warnings, 303 tests pass.
  • In a fresh app: with .shellui/bin deleted, dotnet build downloaded Tailwind v4.3.2 and built app.css. With an unreachable version, the build succeeded with the warning.
  • shellui update printed the right counts. init --tailwind gulp failed before Bootstrap was removed.

Shewatipa Tseisi added 7 commits October 3, 2026 17:08
DisposeAsync only caught JSException. After a reload or tab close the circuit is gone, so ShellUI.disposeSidebar throws JSDisconnectedException and Blazor logged it twice per page load.
Command only raised CommandSelected, so items with an Action did nothing on click or Enter. It now runs Action, then raises CommandSelected. CommandPalette is built on Command and gets the same behavior.
…e project

An explicit --tailwind now skips the prompt (it was ignored in interactive mode), an unknown value fails before init touches the project, and with --yes init says that standalone is the default and how to choose npm.
…lui update

The summary counted every requested component as updated, including skipped and failed ones. InstallComponent now reports success.
The standalone Build/ShellUI.targets silently skipped Tailwind when .shellui/bin had no binary, for example after a fresh clone, leaving a stale app.css. The build now downloads the pinned version with MSBuild's DownloadFile and warns if it can't.
Copilot AI balanced review requested due to automatic review settings October 3, 2026 15:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Shewart
Shewart merged commit f043fb8 into main Oct 3, 2026
1 check passed
@Shewart
Shewart deleted the fix/pre-alpha-polish branch October 3, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants