Repository navigation
fix: hash multiline HTML tags before blockquotes - #1085
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Pretty-printed tags with `>` on its own line were split by the blockquote parser. Hash CommonMark open/close tags whose closing `>` sits at blockquote position so makeHtml keeps them intact. Fixes showdownjs#842
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pretty-printed HTML tags with the closing
>on its own line were split by the blockquote parser, so multiline<a …>(and similar) became an escaped paragraph plus a blockquote instead of a real tag.Hash CommonMark open/close tags whose
>sits at blockquote position (\n {0,3}>) in the HTML-block pass before blockquotes run. Fenced code is left alone; one-line tags followed by a real quote still become blockquotes.Fixes #842
Test plan
npx vitest run test/functional/makehtml/testsuite.issues.js -t "842"