Repository navigation
bugfix: warn instead of raising when beat_init fires with another scheduler - #343
Merged
sibson merged 1 commit intoSep 10, 2026
Merged
Conversation
…eduler The receiver is connected on import, so a beat started without -S redbeat.RedBeatScheduler hit AttributeError on lock_key and kept running on the wrong scheduler with only a traceback as the hint. Return early with a warning that names the flag. Fixes #342.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
|
thanks, ✨ 🍰 ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #342
acquire_distributed_beat_lockreadssender.scheduler.lock_key. When redbeat is imported butcelery beatruns without-S redbeat.RedBeatScheduler, the scheduler is Celery'sPersistentScheduler, the receiver raisesAttributeError: 'PersistentScheduler' object has no attribute 'lock_key', and Celery logs the traceback at startup. Beat then keeps running on the wrong scheduler, so the only hint that RedBeat is not in use is a confusing stack trace. #87 and #276 are both this misconfiguration and both ended with "pass --scheduler".This returns early when the scheduler is not a
RedBeatSchedulerand logs a single warning that names the flag. Not a silent guard on purpose: the misconfiguration stays visible, just as one line instead of a traceback.Test in tests/test_scheduler.py (
RedBeatStartupWithAnotherScheduler), errors on main. CHANGES.txt entry under 2.4.3 (unreleased).make test112 OK,make lintclean.