Repository navigation
SanaConform: fix quirk-stat message for foreign drivers with other special stats - #42
Merged
Merged
Conversation
…ecial stats PR #41 fixed the RecordCountSupplied==0 case but left the "unexpected" message in place for a foreign driver that returns its own (non-sana2loop) special-stats records without a DMA-hook-offered entry -- a legitimate, expected result for any driver other than loopback.device, not a real anomaly. Branch on DEVICE= to pick the right message. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SanaConform's quirk-stat message for theRecordCountSupplied==0case against non-sana2loop drivers, found by code review of that PR).SANA2LOOP_SPECIALSTAT_DMA_HOOKS_OFFEREDtype -- still printed "unexpected", which only makes sense when probingloopback.deviceitself.DEVICE=actually namesloopback.device: if not, prints an "expected" message instead of a false "something's wrong" report.Test plan
make dockerbuildsSanaConformclean, no warnings🤖 Generated with Claude Code