Repository navigation
timer.device: GetSysTime and ReadEClock resolve microseconds - #202
Merged
Merged
Conversation
Both read the host clock through DateStamp's 1/50s ticks, so without --clock-mhz every interval a program timed with ReadEClock was a multiple of 20 ms. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without
--clock-mhz,ReadEClockandGetSysTime(and intuition'sCurrentTime) take the host time fromhost_time_secs_micro(), which went throughnow_as_datestamp()and its 1/50 s ticks. Everytv_microwas a multiple of 20000, and every interval a program timed withReadEClocka multiple of 20 ms.That makes
--jittimings useless for short runs. BenchWork under--jit --cpu 68040printed 60.000, 279.999, 300.000 ms and so on. With this change it prints 68.426, 232.098, 313.870 ms.host_time_secs_micro()now readsSystemTimeitself and keepssubsec_micros().DateStampis unchanged. The new testhost_time_has_microsecond_resolutionfails on main.pending_host_break_folds_into_check_signalandpending_host_break_folds_into_waitfail on main as well as on this branch (cargo test -p volamos-core). This PR doesn't touch them.🤖 Generated with Claude Code