Fixed build with OpenJPH system library and updated h5z-htj2k v0.1.1 - #409
Merged
Conversation
bb6bf0cd24 Change includes to use OpenJPH installation exposed include dir git-subtree-dir: lib/h5z-htj2k git-subtree-split: bb6bf0cd24413b01481b6ce096a612a3eba8bfd4
t20100
commented
Aug 26, 2026
| include_dirs=[h5z_htj2k_dir] + get_clib_config("openjph", "include_dirs"), | ||
| libraries=get_clib_config("openjph", "extra_link_args"), | ||
| extra_compile_args=extra_compile_args, | ||
| extra_link_args=get_clib_config("openjph", "extra_link_args"), |
Member
Author
There was a problem hiding this comment.
This fixes an issue only showing up when building with system lib.
t20100
force-pushed
the
update-h5z-htj2k
branch
from
August 26, 2026 14:14
7fa2eb2 to
9c01578
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes building the htj2k filter with OpenJPH from the system (instead of the vendored one).
OpenJPH advertise the default include path when installed, the includes need
openjph/prefix.