4695 silx.gui.fit.FitWidget: fix usage of qt.QFileDialog.getOpenFileName - #4696
Merged
Conversation
woutdenolf
requested changes
Aug 12, 2026
woutdenolf
left a comment
woutdenolf
left a comment
Contributor
There was a problem hiding this comment.
When not functionsfile is functionsfile == "" or functionsfile is None?
Co-authored-by: Wout De Nolf <woutdenolf@users.sf.net>
Co-authored-by: Wout De Nolf <woutdenolf@users.sf.net>
Member
Author
First one. It always return a string. But I can make the condition more explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The PR fix the call of
qt.QFileDialog.getOpenFileName. The call return "(fileName, selectedFilter)" - for PySide6, PySide2, PyQt5 and PyQt6 - which seems different from the C++ API 😢Close #4695
AI Disclosure
Note: bug fix-release to be done.