Skip to content

docs: fix dead browser build download links - #2762

Open
rajanpanth wants to merge 1 commit into
sinonjs:mainfrom
rajanpanth:docs/fix-dead-releases-links
Open

rajanpanth wants to merge 1 commit into
sinonjs:mainfrom
rajanpanth:docs/fix-dead-releases-links

Conversation

@rajanpanth

Copy link
Copy Markdown

The Installation section links to https://sinonjs.org/releases/ and https://sinonjs.org/releases#npm-cdns. Both return 404 — the VitePress rebuild of sinonjs.org dropped the releases section, and there is no releases page in docs/ either, so there is nothing to point the old URLs at.

The pkg/ browser bundle is still published (it's listed in package.json files), so this points readers at it directly on the two CDNs that serve it:

I left the nise changelog link in CHANGES.md alone even though it also 404s, since that file is a historical record of past releases rather than live documentation.

sinonjs.org/releases/ and its #npm-cdns anchor both 404 since the site
was rebuilt; the docs source has no releases page. The pkg/ browser
bundle still ships, so link it on jsDelivr and unpkg instead.

@lbesecker195 lbesecker195 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified: https://sinonjs.org/releases/ returns 404, and both the jsDelivr and unpkg pkg/sinon.js URLs return 200. LGTM.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants