Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Keep sandbox call-order tracking separate from fake factory arguments.
fake.yields()andfake.yieldsAsync()currently pass an extra internal object to callbacks, whilefake.returns()andfake.resolves()without a value return that object instead ofundefined.Attach the existing non-enumerable
sinonContextto the created fake. This also keeps callback fakes in the sandbox's call order.How to verify - mandatory
npm cinpm testandnpm run test-contract(Chrome configured).npm run lintandnpm run prettier:check.The eight added regressions fail before the fix. Node 22, 24 and 26 each pass 1,564 tests; Chrome passes 1,557 tests and the Web Worker test passes. Existing pending tests remain pending.
Checklist for author
npm run lintpasses