[Didr]

Added this while debugging #70 and #71.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Didr]

@copilot go bananas on this PR. Codecov is also complaining about the "documentDataForLog" function missing a test, please add that.

[Copilot]

@copilot go bananas on this PR. Codecov is also complaining about the "documentDataForLog" function missing a test, please add that.

Added table-driven coverage for portrait redaction, the empty-portrait case, and preservation of document fields. internal/apiv1 passes; documentDataForLog is at 100% coverage. Commit: 429571c.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Copilot review overview

🟡 Changes recommended

Debug logs expose personal identity and expiry data contrary to the repository’s privacy policy.

Review effort: Balanced
Findings: 1

Open (1)

• Prevent PII leakage in document debug logs · New

What changed in this PR

Adds debug diagnostics for document parsing in ID scan and process-request flows to investigate issues #70 and #71.

Changes:

• Logs OCR document data with portrait omission.
• Adds expiry-check diagnostic fields.
• Updates and adds related tests.

File	Description
internal/​apiv1/​client.go	Adds document and expiry debug logging.
internal/​apiv1/​liveness_expiry_test.go	Updates expiry tests and tests portrait omission.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Didr]

@copilot would you be so kind to take a look again after #75 was merged?

[Copilot]

@copilot would you be so kind to take a look again after #75 was merged?

Addressed the privacy review finding in 33c27b8. documentDataForLog now returns an allowlisted summary: the document type plus per-field presence and length, with no values. The expiry-check log no longer includes the raw expiry date; it logs the date's length, whether it parsed, days until expiry, and the result. The test now asserts that none of the identity values appear in the logged output. internal/apiv1 tests pass.

[Didr]

Already implemented in #75