Repository navigation
Conversation
…kflow that refuses a branch that does not verify Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
GitHub answers commits/<sha>/pulls on a fork with the upstream's PRs; reporting them under the fork made the numbers unfetchable (sirosfoundation/vc#825 is SUNET/vc#825). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by the org-level version: sirosfoundation/.github#36 (plan-generated branches, verify, glue classification, a reusable workflow and PR comments; no sirosid-dev dependency). This PR should be closed once that direction is agreed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the integration-branch plan. Stacked on #90 (base = its branch; retarget to
mainwhen that merges). Nothing is deployed and no image is built; the workflow has never run.integration.py sync(Re)creates an
integration/<name>branch from a PR list: the base, then one--no-ffmerge per PR head in the order given. Each PR is fetched from its own repo (pull/<n>/head;@shapins a head and fails if the PR has moved). The merge message isMerge PR owner/repo#N @<head9>: <title>, soreportreads the list back offline (no API), and a synced branch always passesverify. A conflict stops it, aborts the merge and leaves the tree clean: it must be resolved in a glue PR that goes in the list, never by hand.--from <branch>takes the PR list (latest heads) of an existing branch, which is how a branch is updated or a drifted one regenerated;--push <remote>force-pushes with a lease..github/workflows/build-integration.ymlworkflow_dispatch(repo, branch, component, pr_repos, optional dockerfile/target/build args). It checks the branch out with full history, runsverifybefore building (a drifted branch is refused), uploads thereportas an artifact, builds with the component's own Dockerfile and a registry cache, and pushesghcr.io/<owner>/integration/<component>:<branch>-<sha7>with labels (revision, branch,org.siros.integration.prs, report sha256) and a provenance attestation. The run summary printscomponent@sha256:...to pin by digest. No dispatch input is interpolated into a shell script;permissionsarecontents: read, packages: write; nolatest.Tests (18 in
tests/test_integration_tool.py, real git repositories)Added for
sync: builds the branch andverify/reportread it back offline; a moved head is refused; a conflict stops it and leaves a clean tree;--frompicks up a PR's newer head; a dirty tree is refused; PR reference parsing. For the workflow: it parses with the documented inputs,verifyprecedes the build (proven: replacing the verify step fails the test), no input reaches a shell, least privilege.actionlintis clean.Not covered, said plainly
dockerfiles/verifier-nymauth.Dockerfile) needs a file that is not in any repo, and the ZK libraries still build from cold inside the vc Dockerfile (the cached builder image is a later step).INTEGRATION_READ_TOKENsecret.integration/gdc-nymauth-v5, the engine branch) still failverify(see scripts/integration.py: report and verify what an integration branch contains #90); regenerating them withsync --fromand the glue-PR conversion of the engine's two local commits is the next step, and needs the owners' OK to pushintegration/*branches.🤖 Generated with Claude Code