Skip to content

chore(deps): upgrade to Angular 22.2.3 and Node 24 - #495

Merged
fjlopez merged 3 commits into
devfrom
ltr/admin-angular-22
Oct 19, 2026
Merged

fjlopez merged 3 commits into
devfrom
ltr/admin-angular-22

Conversation

@fjlopez

@fjlopez fjlopez commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade admin app to Angular 22.2.3, Node 24.22.0 (engines ^24.22.0 || ^26.0.0), and AG Grid Community 32.3.9.
  • Adapt compile/runtime for Angular 22 (Eager change detection, AG Grid APIs, HostListener typing) and keep a green production build.
  • Fix Jest specs for Angular 22 / jsdom realities (ng-reflect-* opt-in, @if (; as), FileReader, Location) and raise the default Jest timeout to 30s.

Test plan

  • nvm use 24.22.0 && npx jest --forceExit → 152 suites / 1884 tests passed (JEST_EXIT:0)
  • npx ng build --configuration=production → BUILD_EXIT:0 (initial ~5.87 MB)
  • Operator visual review of login / post-login screens (screens attached in chat)
  • Do not merge until stack operator lands (STACK-READY handoff only)

Notes

  • No merge requested from this PR owner.
  • CI Node pin updated via .nvmrc / workflow.

Move the admin UI onto Angular 22 / Node 24 with AG Grid 32.3.9,
and adapt Jest specs and timeouts so the suite stays green under the
new runtime (ng-reflect opt-in, HostListener rename, jsdom Location).
angular-eslint 22 tsRecommended fails CI with ~1060 prefer-inject
and prefer-on-push errors on existing NgModule code. Mirror
prefer-standalone: keep those off until a dedicated migrate PR.
Convert the last *ngIf/*ngFor template (side-menu) to @if/@for so
prefer-control-flow stays enforced.
@fjlopez
fjlopez merged commit c2175a5 into dev Oct 19, 2026
1 check passed
@fjlopez

fjlopez commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

CI restore

Head 5fb041d9 (includes 9102a49b lint fix) — build check pass (lint, test:coverage, production build).

Root cause was angular-eslint 22 tsRecommended (prefer-inject / prefer-on-push ~1060 errors). Fix: turn those off like existing prefer-standalone, and migrate the last *ngIf/*ngFor template (side-menu) to @if/@for.

CODE-READY. No merge from this owner.

Visual review screenshots still outstanding (local capture failed); operator gate remains open.

@fjlopez
fjlopez deleted the ltr/admin-angular-22 branch October 20, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant