Repository navigation
fix(admin): restore AG Grid 32 inline editors and language-default URL - #497
Merged
Merged
Conversation
Register CommunityFeaturesModule so date/text cell editors mount again. Build language.default and language-default API URLs without a double slash so Spring Security 7 stops 401ing findByName.
agDateStringCellEditor crashes when HAL Instant ISO values make DataTypeModule infer cellDataType text. Restore datePicker and disable cellDataType inference so Positions Alta/Baja inline edit works on AG Grid 32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AG Grid 32 no longer mounts text, select, or date inline editors unless
CommunityFeaturesModuleis registered. Date columns also crashed: HAL Instant ISO values madeDataTypeModuleinfercellDataTypetext, andagDateStringCellEditorthen threw. Separately, default-language calls built…/api//…URLs, and Spring Security 7 returned 401 forfindByName, so Set as Default stayed disabled.What changed
CommunityFeaturesModulein the shared data grid and the literal-translations grid.datePickereditor withcellDataType: false.LanguageServicebuildslanguage.defaultandlanguage-defaultURLs with a single slash.CHANGELOG.md.Scope
Inline grid editors and the language-default API URLs. App version stays 1.2.9. Do not merge from this PR; the operator merges.
Commits
5abc7051restore AG Grid 32 editors and the language-default URL8bcd38f4Instant-safedatePickerfor Positions Alta/BajaVerification
CI on this tip is the gate.