Skip to content

Root README requires a SonarCloud quality gate and links Discussions, which is disabled #112

Open

Description

@fjlopez

What is wrong

The root README says a SonarCloud quality gate must pass in review, and it links GitHub Discussions for this repository. No workflow in this repository runs a quality gate. Discussions is disabled.

Where

  • README.md line 66 lists SonarCloud as infrastructure. Line 1160 says the quality gate must pass. Lines 1193-1196 link the Backend Core, Admin App, and Proxy Middleware dashboards. Line 1230 lists SonarCloud under Quality. Line 1175 links https://github.com/sitmun/sitmun-application-stack/discussions.
  • Workflows in this repository are .github/workflows/e2e.yml, liquibase-immutability.yml, liquibase-seed-identity.yml, liquibase-upgrade.yml, and stale.yml. None invoke Sonar.
  • GET /repos/sitmun/sitmun-application-stack returns has_discussions: false.

Older component workflows do not supply the gate this README describes:

  • sitmun-backend-core on origin/main has .github/workflows/sonarqube-analysis.yml, triggered on master. The branch list has main and dev and no master. gh run list for that workflow returned no runs.
  • sitmun-proxy-middleware on origin/main runs ./gradlew sonarqube for pushes to main. The last five runs failed in "Set up Java 17", and "Analyze" was skipped. The workflow file does not wait for a quality gate. dev does not contain that file. The setup-java log text was not fetched.
  • Admin and viewer workflows on main and dev have no Sonar job. Whether the linked dashboards still resolve was not checked.

Why it matters

Review can demand a gate that CI never evaluates, and the Discussions link does not open a forum.

Smallest fix

Remove the quality-gate requirement and the Discussions link from this README. If the gate should stay, add a workflow on this repository that fails the pull request when the gate fails, and enable Discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingconfirmedReproduced / accepted defect; exempt from stale botdocumentationImprovements or additions to documentation

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions